- 
                Notifications
    You must be signed in to change notification settings 
- Fork 260
Add zswap accounting #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zswap accounting #686
Conversation
| @mihalicyn I've kept this as draft for now since it doesn't include any checks for kernel zswap support. | 
c79fcb7    to
    22ea9a2      
    Compare
  
    | We've discussed this PR privately with Kadin and he will post a new version soon. | 
22ea9a2    to
    67bd198      
    Compare
  
    7d4b39f    to
    ecef210      
    Compare
  
    | Ready for review ✅ | 
Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Kadin Sayani <[email protected]>
ecef210    to
    bc8518c      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks awesome, except one small thing with struct lxcfs_opts.
Signed-off-by: Kadin Sayani <[email protected]>
bc8518c    to
    4ada6f6      
    Compare
  
    Signed-off-by: Kadin Sayani <[email protected]>
The following new metrics are now available in /proc/meminfo: - Zswap: the total amount of memory consumed by the zswap compression backend - Zswapped: amount of application memory swapped out to zswap Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Kadin Sayani <[email protected]>
4ada6f6    to
    c503b12      
    Compare
  
    | @mihalicyn should be good for another review | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @kadinsayani !
LGTM
Adds support for reporting zswap memory statistics in /proc/meminfo.